[ovs-dev] [PATCH] bridge: Append the ovs_rundir to socket.

Ben Pfaff blp at nicira.com
Tue Jan 22 17:36:25 UTC 2013

On Fri, Jan 18, 2013 at 08:09:55PM -0500, Pavithra Ramesh wrote:
> If socket path specified in the set-controller command is
> relative to ovs_rundir(), append the directory name to target.
> Bug#14029
> Signed-off-by: Pavithra Ramesh <paramesh at vmware.com>

This code doesn't own c->target (it belongs to the database) yet it
modifies it anyway:

+                   free(c->target);
+                   c->target = new_target;

That cannot work reliably.  Please find another way.  One good candidate
is to modify unix_open() in lib/stream-unix.c.  I would start by
modifying that function to use ovs_rundir() as a default base directory,
then see how many unit tests it breaks (as a proxy for how likely it is
to break real setups).



More information about the dev mailing list