[ovs-dev] [PATCH] dpif-linux: Report dropped lost messages at WARN level.

Justin Pettit jpettit at nicira.com
Fri Jan 25 22:38:22 UTC 2013


Messages about packets being lost are logged at level WARN, but when
they were generated at a high rate, those consolidated messages were
logged at ERR.  This changes to consolidated messages to be logged at
WARN, too.

Thanks to Ben Pfaff for quickly suggesting the culprit.

Bug #14783

Reported-by: James Schmidt <jschmidt at nicira.com>
Signed-off-by: Justin Pettit <jpettit at nicira.com>
---
 lib/dpif-linux.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
index 4425f6f..267f6e7 100644
--- a/lib/dpif-linux.c
+++ b/lib/dpif-linux.c
@@ -1929,7 +1929,7 @@ report_loss(struct dpif *dpif_, struct dpif_channel *ch)
     static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 5);
     struct ds s;
 
-    if (VLOG_DROP_ERR(&rl)) {
+    if (VLOG_DROP_WARN(&rl)) {
         return;
     }
 
-- 
1.7.5.4




More information about the dev mailing list