[ovs-dev] [PATCH 4/6] datapath: Remove tunnel configuration sequence number.

Jesse Gross jesse at nicira.com
Fri Jan 25 23:54:25 UTC 2013


When tunnel header caching was in use, it was necessary to detect
configuration changes that would invalidate the cache.  This was
done using a sequence number on the configuration.  However, now
that header caching has been removed the sequence number is no
longer necessary.

Signed-off-by: Jesse Gross <jesse at nicira.com>
---
 datapath/tunnel.c |    2 --
 datapath/tunnel.h |    3 ---
 2 files changed, 5 deletions(-)

diff --git a/datapath/tunnel.c b/datapath/tunnel.c
index 02c642e..6193891 100644
--- a/datapath/tunnel.c
+++ b/datapath/tunnel.c
@@ -858,8 +858,6 @@ int ovs_tnl_set_options(struct vport *vport, struct nlattr *options)
 		goto error;
 	}
 
-	mutable->seq = old_mutable->seq + 1;
-
 	/* Parse the others configured by userspace. */
 	err = tnl_set_config(ovs_dp_get_net(vport->dp), options, tnl_vport->tnl_ops,
 			     vport, mutable);
diff --git a/datapath/tunnel.h b/datapath/tunnel.h
index 8cd2167..b047549 100644
--- a/datapath/tunnel.h
+++ b/datapath/tunnel.h
@@ -94,7 +94,6 @@ static inline void port_key_set_net(struct port_lookup_key *key, struct net *net
  * @key: Used as key for tunnel port.  Configured via OVS_TUNNEL_ATTR_*
  * attributes.
  * @rcu: RCU callback head for deferred destruction.
- * @seq: Sequence number for distinguishing configuration versions.
  * @tunnel_hlen: Tunnel header length.
  * @out_key: Key to use on output, 0 if this tunnel has no fixed output key.
  * @flags: TNL_F_* flags.
@@ -105,8 +104,6 @@ struct tnl_mutable_config {
 	struct port_lookup_key key;
 	struct rcu_head rcu;
 
-	unsigned seq;
-
 	/* Configured via OVS_TUNNEL_ATTR_* attributes. */
 	__be64	out_key;
 	u32	flags;
-- 
1.7.9.5




More information about the dev mailing list