[ovs-dev] [PATCH] ofproto: Maintain "expirable" list for "add" flow_mod with replaced rule.

Justin Pettit jpettit at nicira.com
Sat Jan 26 01:22:49 UTC 2013


On Jan 25, 2013, at 3:21 PM, Ben Pfaff <blp at nicira.com> wrote:

> @@ -4858,6 +4858,7 @@ oftable_replace_rule(struct rule *rule)
> 
>     victim = rule_from_cls_rule(classifier_replace(&table->cls, &rule->cr));
>     if (victim) {
> +        list_remove(&victim->expirable);

In oftable_remove_rule(), there's a check whether the list is empty before removing it.  While it doesn't really matter, it might be nice to keep them looking consistent.

Otherwise, looks good.

--Justin





More information about the dev mailing list