[ovs-dev] [PATCH] worker: Don't have worker abort when parent dies.

Justin Pettit jpettit at nicira.com
Sat Jan 26 02:17:03 UTC 2013


Depending on how forcefully the parent process is killed, the worker
could abort when trying to read or write on their shared socket.  This
changes those errors from VLOG_ABORT to VLOG_FATAL so that a core isn't
generated.

Bug #14821

Reported-by: Amey Bhide <abhide at nicira.com>
Signed-off-by: Justin Pettit <jpettit at nicira.com>
---
 lib/worker.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/worker.c b/lib/worker.c
index 6ca05cd..b0f1a82 100644
--- a/lib/worker.c
+++ b/lib/worker.c
@@ -345,7 +345,7 @@ worker_reply_iovec(const struct iovec *iovs, size_t n_iovs,
          * to avoid missing log messages. */
         VLOG_INFO("send failed (%s)", strerror(error));
     } else if (error) {
-        VLOG_ABORT("send failed (%s)", strerror(error));
+        VLOG_FATAL("send failed (%s)", strerror(error));
     }
 
     free(all_iovs);
@@ -379,7 +379,7 @@ worker_main(int fd)
             /* Main process closed the IPC socket.  Exit cleanly. */
             break;
         } else if (error != EAGAIN) {
-            VLOG_ABORT("RPC receive failed (%s)", strerror(error));
+            VLOG_FATAL("RPC receive failed (%s)", strerror(error));
         }
 
         poll_fd_wait(server_sock, POLLIN);
-- 
1.7.5.4




More information about the dev mailing list