[ovs-dev] [PATCH] ofproto-dpif: Clear revalidation flags only once, not per-ofproto.
Ben Pfaff
blp at nicira.com
Mon Jan 28 18:45:58 UTC 2013
Found by inspection.
CC: Ethan Jackson <ethan at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
---
I noticed this while reviewing one of your "tunnel" patches.
ofproto/ofproto-dpif.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 1d08baf..d207b52 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -844,6 +844,10 @@ type_run(const char *type)
case REV_INCONSISTENCY: COVERAGE_INC(rev_inconsistency); break;
}
+ /* Clear the revalidation flags. */
+ tag_set_init(&backer->revalidate_set);
+ backer->need_revalidate = 0;
+
HMAP_FOR_EACH (ofproto, all_ofproto_dpifs_node, &all_ofproto_dpifs) {
struct facet *facet;
@@ -851,10 +855,6 @@ type_run(const char *type)
continue;
}
- /* Clear the revalidation flags. */
- tag_set_init(&backer->revalidate_set);
- backer->need_revalidate = 0;
-
HMAP_FOR_EACH (facet, hmap_node, &ofproto->facets) {
if (need_revalidate
|| tag_set_intersects(&revalidate_set, facet->tags)) {
--
1.7.2.5
More information about the dev
mailing list