[ovs-dev] [tunnel 09/11] lib: Switch to flow based tunneling.

Ethan Jackson ethan at nicira.com
Tue Jan 29 02:00:01 UTC 2013

> Normally the author and the first sign-off should be the same.  Is
> this adapted with significant changes from a patch of Jesse's?  It's
> reasonable to change the authorship in that case if the changes seem
> significant enough but then one would ordinarily change the first
> sign-off to a textual credit.  Or sometimes I've done it as:
>     Signed-off-by: Ethan Jackson <ethan at nicira.com>
>     Co-authored-by: Jesse Gross <jesse at nicira.com>
>     Signed-off-by: Jesse Gross <jesse at nicira.com>

Yep, that's basically what happened.  There's very little left of
Jesse's original patch, so I think it's appropriate for me to claim
authorship.  I like the Co-authored-by idea so I've added it.

> This is an odd change because, just below, there is a new comment that
> reads NULL instead of null:
> +    struct tnl_port *tnl_port;  /* Tunnel handle, or NULL. */

Oops, I had actually intended to change the tnl_port comment to "null"
as that's the convention.  I've changed that one to be lower case
"null", and the ofbundle one I've left untouched.

> Here, I understand why we skip 'tnl_backers'.  Why do we skip 'ports'?

Good catch, that was just a mistake.  I've changed it to simply check
tnl_backers. */

> ofproto-dpif is getting to be such a mess.  We need to schedule time
> for cleanup.



More information about the dev mailing list