[ovs-dev] [PATCH 01/18] fix an obvious mistake in a test of IFM_ETHER

Ed Maste emaste at freebsd.org
Thu Jan 31 16:08:01 UTC 2013


On 31 January 2013 05:49, YAMAMOTO Takashi <yamamoto at valinux.co.jp> wrote:
> From: YAMAMOTO Takashi <yamt at mwd.biglobe.ne.jp>
>
> -    if (!IFM_TYPE(ifmr.ifm_current) & IFM_ETHER) {
> +    if (!(IFM_TYPE(ifmr.ifm_current) & IFM_ETHER)) {
>          VLOG_DBG_RL(&rl, "%s: doesn't appear to be ethernet",
>                      netdev_get_name(netdev));

Should probably be IFM_TYPE(ifmr.ifm_current) != IFM_ETHER instead as
IFM_TYPE masks the network type field.



More information about the dev mailing list