[ovs-dev] [PATCH 10/18] some ctype related casts to suppress gcc warnings on NetBSD.

Ben Pfaff blp at nicira.com
Thu Jan 31 17:19:24 UTC 2013


On Thu, Jan 31, 2013 at 07:49:44PM +0900, YAMAMOTO Takashi wrote:
> From: YAMAMOTO Takashi <yamt at mwd.biglobe.ne.jp>
> 
> where it can't be EOF, cast a value to unsigned char before passing it
> to ctype functions to avoid unintended sign extension.
> 
> Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>

Thanks, these look good except that we usually put a space following the
")" in a cast, see CodingStyle:

...
    Exception 2: Put a space between the () used in a cast and the
    expression whose type is cast: (void *) 0.
...

Will you please make that change and resubmit?



More information about the dev mailing list