[ovs-dev] [PATCH 15/18] implement set_etheraddr for NetBSD

Ben Pfaff blp at nicira.com
Thu Jan 31 17:43:58 UTC 2013


On Thu, Jan 31, 2013 at 07:49:49PM +0900, YAMAMOTO Takashi wrote:
> From: YAMAMOTO Takashi <yamt at mwd.biglobe.ne.jp>
> 
> Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>

I see a number of repeated blocks here of the form:
> +        int saved_errno = errno;
> +
> +        close(s);
> +        return saved_errno;
We would usually put this at the end of the function following an
"error:" label.  (Usually I would just give "saved_errno" the name
"error".)

Our usual comment style would write:
> +    /*
> +     * get the old address, add new one, and then remove old one.
> +     */
as:
    /* Get the old address, add new one, and then remove old one. */

Again we would usually use EOPNOTSUPP instead of ENOTSUP.

Thanks,

Ben.



More information about the dev mailing list