[ovs-dev] [PATCH 16/18] implement get_stats for NetBSD

Ben Pfaff blp at nicira.com
Thu Jan 31 17:46:24 UTC 2013

On Thu, Jan 31, 2013 at 07:49:50PM +0900, YAMAMOTO Takashi wrote:
> From: YAMAMOTO Takashi <yamt at mwd.biglobe.ne.jp>
> Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>

Did you consider opening an AF_LINK socket only once instead of once per
call?  The netdev_get_stats() function can sometimes be called often, so
it may be best to avoid unneeded system calls.

Is there a reason not to squash this patch (and the previous one) into
the earlier patch that modified netdev-bsd?  I do not see anything that
keeps it conceptually distinct from that patch.



More information about the dev mailing list