[ovs-dev] [PATCH] Keep all of tunnel metadata in flow.

Justin Pettit jpettit at nicira.com
Wed Jul 3 03:49:10 UTC 2013


On Jul 2, 2013, at 7:11 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Tue, Jul 02, 2013 at 06:27:18PM -0700, Justin Pettit wrote:
>> From: Jarno Rajahalme <jarno.rajahalme at nsn.com>
>> 
>> Do not clear tunnel metadata on tunnel input.
>> 
>> This is a backport of 4110a57 (Keep all of tunnel metadata in
>> flow.) to branch-1.10.  This fixes an issue with received tunnel
>> traffic and megaflows.  xlate_actions() calls tnl_port_should_receive()
>> to determine whether it should un-wildcard the tunnel fields.  Without
>> this commit, the original flow's tunnel information is zeroed and is
>> unavailable for tnl_port_should_receive()'s use to determine whether
>> it's a tunnel flow or not.  This resulted in some tunnel traffic
>> being wildcarded inappropriately.
>> 
>> Bug #18277.
>> 
>> Signed-off-by: Justin Pettit <jpettit at nicira.com>
>> Signed-off-by: Jarno Rajahalme <jarno.rajahalme at nsn.com>
>> Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> This looks good to me, but I believe that it is in fact a backport to
> 1.11 (not 1.10) since only 1.11 uses megaflows.


Whoops.  I fixed the commit message and pushed.  Thanks for the review.

--Justin







More information about the dev mailing list