[ovs-dev] [PATCH] testsuite: make tests match with the tested code

[Ben Pfaff]

On Mon, Jul 08, 2013 at 02:44:47AM +0000, YAMAMOTO Takashi wrote:
> > Does this mean that NetBSD's /proc/self/fd does not work for opening files?
> 
> it probably works.  but unlike linux, netbsd's procfs is somewhat optional.
> procfs might not be mounted on every systems.  besides that, i personally
> don't want to wide spread the use of the feature esp. for things like this,
> for which there are alternative solutions.

If it works, then why does the test fail?  If procfs isn't mounted,
then it should get skipped.

> > A better solution would be, instead of testing uname, to test whether proc
> > works in the required way. That could be done from configure and tested
> > both from C and from the test suite.
> 
> i'm not sure if a configure time test is appropriate for this.

I agree, I didn't realize that there would be build vs. host issues.

> while i don't claim the patch i submitted is an ideal solution,
> it fixes the existing problem.

I don't understand the existing problem yet (see above).  Can you
explain it better?