[ovs-dev] [netlink-errmsg v3] datapath: add netlink error message to help kernel userspace integration.

[Jesse Gross]

Thanks, I just pushed a patch for that directly to the affected branches.

On Wed, Jul 3, 2013 at 5:28 PM, Andy Zhou <azhou at nicira.com> wrote:
> Thanks for those changes.  The messages are more consistent now.
>
>>
>> @@ -1191,14 +1197,15 @@ int ipv4_tun_from_nlattr(const struct nlattr
>> *attr,
>>   };
>>
>>   if (type > OVS_TUNNEL_KEY_ATTR_MAX) {
>> - OVS_NLERR("Unexpected IPv4 tunnel attribute. (type = %d, MAX=%d)\n",
>> + OVS_NLERR("Unknown IPv4 tunnel attribute (type=%d, max=%d)\n",
>>   type, OVS_TUNNEL_KEY_ATTR_MAX);
>>   return -EINVAL;
>>  }
>>
> Missing period?
>
>>
>>   if (ovs_tunnel_key_lens[type] != nla_len(a)) {
>> - OVS_NLERR("IPv4 tunnel attribute type %d length %d does not equal to
>> expected length %d.\n",
>> - type, nla_len(a), ovs_tunnel_key_lens[type]);
>> + OVS_NLERR("IPv4 tunnel attribute type has unexpected "
>> +  " legnth (type=%d, length=%d, expected=%d.)\n",
>> +  type, nla_len(a), ovs_tunnel_key_lens[type]);
>>   return -EINVAL;
>>   }
>>
> .) -> ). ?
>
>>
>>
>
X-CudaMail-Whitelist-To: dev at openvswitch.org