[ovs-dev] [PATCH V3] feature: Create specific types for ofp and odp port

[Ben Pfaff]

On Thu, Jul 11, 2013 at 12:44:50PM +0900, YAMAMOTO Takashi wrote:
> > On Tue, Jul 09, 2013 at 05:18:34PM +0900, YAMAMOTO Takashi wrote:
> >> hi,
> >> 
> >> > @@ -708,9 +711,7 @@ dpif_netdev_flow_from_nlattrs(const struct nlattr *key, uint32_t key_len,
> >> >          return EINVAL;
> >> >      }
> >> >  
> >> > -    if (flow->in_port < OFPP_MAX
> >> > -        ? flow->in_port >= MAX_PORTS
> >> > -        : flow->in_port != OFPP_LOCAL && flow->in_port != OFPP_NONE) {
> >> > +    if (odp_to_u32(flow->in_port.odp_port) >= MAX_PORTS) {
> >> >          return EINVAL;
> >> >      }
> >> 
> >> it seems that this change broke packet_out with in_port=controller.
> > 
> > Oops.
> > 
> > I sent out a fix for review:
> >         http://openvswitch.org/pipermail/dev/2013-July/029436.html
> > Can you confirm that it fixes the problem for you?
> 
> thanks.
> 
> i haven't tested your patch but it seems fine.
> it's mostly identical to my local patch which is working for me.

Thanks for the review.  I applied this to master.