[ovs-dev] [PATCH] datapath: Use RCU lock for dp dump operation.

Jesse Gross jesse at nicira.com
Sat Jul 13 01:21:55 UTC 2013


On Fri, Jul 12, 2013 at 4:37 PM, Pravin B Shelar <pshelar at nicira.com> wrote:
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index 2f02f71..09367cf 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -1902,7 +1903,7 @@ static int ovs_dp_cmd_dump(struct sk_buff *skb, struct netlink_callback *cb)
>         int skip = cb->args[0];
>         int i = 0;
>
> -       ovs_lock();
> +       rcu_read_lock();
>         list_for_each_entry(dp, &ovs_net->dps, list_node) {

I don't think we're maintaining this list in an RCU-safe manner at the moment.
X-CudaMail-Whitelist-To: dev at openvswitch.org



More information about the dev mailing list