[ovs-dev] [threads v2 06/13] latch: New module for a thread-safe, signal-safe, pollable doorbell.

[Ed Maste]

On 12 July 2013 17:54, Ben Pfaff <blp at nicira.com> wrote:

> Signed-off-by: Ben Pfaff <blp at nicira.com>
>

Acked-by: Ed Maste <emaste at freebsd.org>

with one comment,

diff --git a/lib/latch.c b/lib/latch.c
> +void
> +(latch_wait)(const struct latch *latch, const char *where)
>
...

> diff --git a/lib/latch.h b/lib/latch.h
> +#define latch_wait(latch) latch_wait(latch, SOURCE_LOCATOR)
>

This seems like it will be confusing for those who aren't C preprocessor
gurus, and might trip up source indexing / analysis tools.  I see that
there are a few other examples in OVS already though.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130715/5a6003f0/attachment-0003.html>