[ovs-dev] [threads v2 06/13] latch: New module for a thread-safe, signal-safe, pollable doorbell.

[Ben Pfaff]

On Mon, Jul 15, 2013 at 09:24:44AM -0400, Ed Maste wrote:
> On 12 July 2013 17:54, Ben Pfaff <blp at nicira.com> wrote:
> 
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> >
> 
> Acked-by: Ed Maste <emaste at freebsd.org>

Thanks, I applied this to master.

I added some comments, since I"d forgotten to do that earlier.

> with one comment,
> 
> diff --git a/lib/latch.c b/lib/latch.c
> > +void
> > +(latch_wait)(const struct latch *latch, const char *where)
> >
> ...
> 
> > diff --git a/lib/latch.h b/lib/latch.h
> > +#define latch_wait(latch) latch_wait(latch, SOURCE_LOCATOR)
> >
> 
> This seems like it will be confusing for those who aren't C preprocessor
> gurus, and might trip up source indexing / analysis tools.  I see that
> there are a few other examples in OVS already though.

That's a good point.  I'll send a separate patch to improve the
situation.