[ovs-dev] [PATCH net-next v2 2/2] datapath: Restructure vxlan tunneling.

[Pravin Shelar]

On Thu, Jul 18, 2013 at 2:47 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Tue, Jul 16, 2013 at 9:06 AM, Pravin B Shelar <pshelar at nicira.com> wrote:
>> diff --git a/datapath/linux/compat/flow_dissector.c b/datapath/linux/compat/flow_dissector.c
>> new file mode 100644
>> index 0000000..f5fca26
>> --- /dev/null
>> +++ b/datapath/linux/compat/flow_dissector.c
>> @@ -0,0 +1,202 @@
>> +
>> +#include <linux/ip.h>
>> +#include <linux/ipv6.h>
>> +#include <linux/if_vlan.h>
>> +#include <net/ip.h>
>> +#include <net/ipv6.h>
>> +#include <linux/igmp.h>
>> +#include <linux/icmp.h>
>> +#include <linux/sctp.h>
>> +#include <linux/dccp.h>
>> +#include <linux/if_tunnel.h>
>> +#include <linux/if_pppox.h>
>> +#include <linux/ppp_defs.h>
>> +#include <net/flow_keys.h>
>> +
>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37)
>
> It might be better to put all of these includes in the version since I
> think it will make the file otherwise empty on new kernels.
>
ok.

>> diff --git a/datapath/vport-vxlan.c b/datapath/vport-vxlan.c
>> index 7ff51fd..eea5803 100644
>> --- a/datapath/vport-vxlan.c
>> +++ b/datapath/vport-vxlan.c
>> @@ -209,10 +103,12 @@ static struct vport *vxlan_tnl_create(const struct vport_parms *parms)
>>         struct net *net = ovs_dp_get_net(parms->dp);
>>         struct nlattr *options = parms->options;
>>         struct vxlan_port *vxlan_port;
>> +       struct vxlan_handler *vh;
>>         struct vport *vport;
>> +       bool create = true;
> [...]
>> +       vh = vxlan_handler_add(net, htons(dst_port), vxlan_rcv,
>> +                              vport, OVS_VXLAN_RCV_PRIORITY, create);
>
> Does create really need to be a variable?

ok.