[ovs-dev] [PATCH] datapath: remove RCU annotation from flow->mask

Andy Zhou azhou at nicira.com
Mon Jul 22 22:08:13 UTC 2013


Done.


On Mon, Jul 22, 2013 at 2:53 PM, Jesse Gross <jesse at nicira.com> wrote:

> OK, although the patch also needs a signed-off-by from you and I think
> that we can also remove an ugly cast from ovs_flow_free(). Do you just
> want to send out a new version?
>
> On Mon, Jul 22, 2013 at 2:35 PM, Andy Zhou <azhou at nicira.com> wrote:
> > Sorry forgot to mention Ben reported this issue. Jesse, would you please
> add
> > it before committing?
> >
> >
> > On Mon, Jul 22, 2013 at 2:30 PM, Ben Pfaff <blp at nicira.com> wrote:
> >>
> >> On Mon, Jul 22, 2013 at 02:28:04PM -0700, Andy Zhou wrote:
> >> > After a mask is assigned to a flow, it will not change for the life of
> >> > the flow. Since flow access is protected by RCU lock, access to
> >> > flow->mask after getting a flow is always safe.
> >> >
> >> > Suggested-by: Jesse Gross <jesse at nicira.com>
> >>
> >> This patch fixes the warning for me.
> >>
> >> (This is not a review of the patch itself.)
> >>
> >> Tested-by: Ben Pfaff <blp at nicira.com>
> >
> >
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130722/6a1956fb/attachment-0003.html>


More information about the dev mailing list