[ovs-dev] [PATCH 2/5] ovs-bugtool: Separate capability for general network info.

Ben Pfaff blp at nicira.com
Tue Jul 23 18:27:59 UTC 2013


On Mon, Jul 22, 2013 at 12:17:06PM -0700, Gurucharan Shetty wrote:
> Current situation is that CAP_NETWORK_STATUS has a max size of 50 MB.
> When we have around 100,000 openflow flows, we over-run that size
> by just running the "ovs-ofctl dump-flows" command. All the openvswitch
> commands run through the plugin scripts in this repo won't have its
> data stored in the debug bundle in this case as they are part of
> CAP_NETWORK_STATUS too. One option to correct this is to increase
> the CAP_NETWORK_STATUS max size to a higher number. But CAP_NETWORK_STATUS
> also includes a bunch of general network related information collected
> by running commands like ethtool, tc etc. and we probably want to limit
> the data collected through those commands.
> 
> With this commit, we create a new capability called CAP_NETWORK_INFO
> and collect general network related information through them. For OVS
> related information, we continue to use CAP_NETWORK_STATUS, but remove
> the maximum size restriction. One rationale to keep OVS related
> information in CAP_NETWORK_STATUS is because xen-bugtool probably expects
> OVS information in that capability.
> 
> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>

The split seems reasonable.  But I am not sure that the names are
good, because I'm not sure I know the difference between "info" and
"status".  Did you try to think of more descriptive names?



More information about the dev mailing list