[ovs-dev] [thread-safety 09/11] tunnel: Make the ofproto-dpif tunnel module thread safe.

[Ben Pfaff]

On Fri, Jul 26, 2013 at 06:07:10PM -0700, Ethan Jackson wrote:
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

GCC says:
    ../ofproto/tunnel.c: In function ‘tnl_port_del’:
    ../ofproto/tunnel.c:191: error: unused variable ‘tnl_port’

The logging code in tnl_port_receive() is really fucking weird (not
your fault).  I assume it used to make sense.

There's a doubled space after the ? in tnl_port_send() here:
    out_port = tnl_port ?  tnl_port->match.odp_port : ODPP_NONE;

In tnl_port_send() and tnl_port_receive(), the local variable
'tnl_port' may be marked const.

With those comments,
Acked-by: Ben Pfaff <blp at nicira.com>