[ovs-dev] [PATCH 1/2] ofproto-dpif: Unset DPIF_FP_MODIFY flag when creating a new flo

Andy Zhou azhou at nicira.com
Tue Jul 30 17:33:23 UTC 2013


This is a good idea. I will send out another patch implementing this.



On Tue, Jul 30, 2013 at 10:20 AM, Ben Pfaff <blp at nicira.com> wrote:

> On Tue, Jul 30, 2013 at 12:24:43AM -0700, Andy Zhou wrote:
> > Remove the DPIF_FP_MODIFY flag when creating a new flow. When flows
> arrive in
> > a batch, userspace may push down multiple unique flow definitions that
> > overlap when wildcards are applied. Kernels support flow wildcarding
> > will reject these flow as duplicates (EEXIST), which will be logged
> > at a lower logging level.
> >
> > Signed-off-by: Andy Zhou <azhou at nicira.com>
>
> This seems reasonable.
>
> There are two other places that specify DPIF_FP_* flags.  Patch 2/2
> addresses one of them.  But I wonder whether subfacet_install(), the
> other place, should also change.  It always uses DPIF_FP_CREATE |
> DPIF_FP_MODIFY.  Should it use only DPIF_FP_CREATE if subfacet->path
> == SF_NOT_INSTALLED and only DPIF_FP_MODIFY otherwise?
>
> Acked-by: Ben Pfaff <blp at nicira.com>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130730/9cb2721b/attachment-0003.html>


More information about the dev mailing list