[ovs-dev] [thread-safety 04/11] lacp: Make the LACP module thread safe.

Ethan Jackson ethan at nicira.com
Tue Jul 30 22:23:51 UTC 2013


> In lacp_unref(), I think we need to move list_remove(&lacp->node);
> inside the lock/unlock.  Otherwise we have a race here where
> lacp_find() can grab an entry that is being destroyed.

Good catch.  I fixed this, and also systematically added lock
annotations to all of the function definitions as this would have
caught bugs in other patches.

Thanks for the review.  I'll merge this once the thread safety
annotation patch is in.

Ethan
X-CudaMail-Whitelist-To: dev at openvswitch.org



More information about the dev mailing list