[ovs-dev] [thread-safety 09/11] tunnel: Make the ofproto-dpif tunnel module thread safe.

Ethan Jackson ethan at nicira.com
Wed Jul 31 01:52:13 UTC 2013


> GCC says:
>     ../ofproto/tunnel.c: In function ‘tnl_port_del’:
>     ../ofproto/tunnel.c:191: error: unused variable ‘tnl_port’

Thanks, due to a series of unfortunate events, for a while I had
-Wno-unused on in my compiler and missed this.

> The logging code in tnl_port_receive() is really fucking weird (not
> your fault).  I assume it used to make sense.

Agreed.


Thanks for the review.  I'm also going to annotate all the functions
before merging this.

Ethan
X-CudaMail-Whitelist-To: dev at openvswitch.org



More information about the dev mailing list