[ovs-dev] [PATCH V2 01/11] clang: Add annotations for thread safety check.

Ben Pfaff blp at nicira.com
Wed Jul 31 19:55:33 UTC 2013


On Tue, Jul 30, 2013 at 10:17:50PM -0700, Alex Wang wrote:
> Thanks Ben for your review, very glad to see this applied.
> 
> On Tue, Jul 30, 2013 at 9:40 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > On Tue, Jul 30, 2013 at 03:31:48PM -0700, Alex Wang wrote:
> > > From: Ethan Jackson <ethan at nicira.com>
> > >
> > > This commit adds annotations for thread safety check. And the
> > > check can be conducted by using -Wthread-safety flag in clang.
> > >
> > > Co-authored-by: Alex Wang <alexw at nicira.com>
> > > Signed-off-by: Alex Wang <alexw at nicira.com>
> > > Signed-off-by: Ethan Jackson <ethan at nicira.com>
> >
> > The lockfile logging change in this patch caused test failures for me.
> > I didn't see a reason for the logging change, so I just dropped it.  We
> > can do it in a separate patch if there is a good reason..
> 
> This actually relates to the unresolved comment. I misunderstood.
> I thought you want to add error message to where EDEADLK is returned.
> And that's why I added VLOG_ERR and modified the lockfile.at.
> 
> So, I'm still not very clear. Do you suggest that we should show 'where' in
> "ovs_abort()" in lib/ovs-thread.c? Could you give an example of using the
> 'where'?

Yes, that's what I mean.



More information about the dev mailing list