[ovs-dev] [PATCH] Always use valid ids pointer in dec_ttl_cnt_ids_from_openflow()

Ben Pfaff blp at nicira.com
Tue Jun 4 17:24:04 UTC 2013

On Mon, Jun 03, 2013 at 02:46:30PM +0900, Simon Horman wrote:
> Always update the ids pointer after calling ofpbuf_put()
> to ensure that it is valid when accessed.
> During testing a case came up where the call to ofpbuf_put() in the
> for (i = 0; i < ids->n_controllers; i++) loop would cause the underlying
> buffer to be reallocated. This resulted in ids->n_controllers being an
> incorrect value, the loop continuing on longer than desired and finally a
> segmentation fault.
> Reported-by: Joe Stringer <joe at wand.net.nz>
> Signed-off-by: Simon Horman <horms at verge.net.au>

Applied to master, thanks.

More information about the dev mailing list