[ovs-dev] [PATCH V1] bridge.c: Change variable "ofport" type in "struct if_cfg" and "struct iface"

Ben Pfaff blp at nicira.com
Tue Jun 4 18:01:11 UTC 2013

On Tue, Jun 04, 2013 at 10:35:03AM -0700, Alex Wang wrote:
> On Tue, Jun 4, 2013 at 10:17 AM, Ben Pfaff <blp at nicira.com> wrote:
> > Second, iface_configure_qos() tests ->ofp_port for >= 0, which no
> > longer makes sense.  I guess it should test for ->ofp_port !=
> > OFPP_NONE now.
> >
> Thanks for finding this out. This is what I'm most afraid of, in doing such
> change. Just wish I can catch them all. ;D

I usually find this kind of issue by commenting out the declaration of
the struct member and recompiling.  Then the compiler complains each
time the struct member is mentioned in the source code, so you can
easily examine each instance.  That is how I found this problem in



More information about the dev mailing list