[ovs-dev] [PATCH] datapath: Add support for linux kernel 3.9.

Pravin Shelar pshelar at nicira.com
Tue Jun 4 20:20:58 UTC 2013


On Mon, Jun 3, 2013 at 6:40 AM, James Page <james.page at ubuntu.com> wrote:
> Hi Pravin
>
>
> On 13/05/13 23:29, Pravin B Shelar wrote:
>>
>> diff --git a/datapath/vport-netdev.c b/datapath/vport-netdev.c
>> index 4e7342c..c1ee3db 100644
>> --- a/datapath/vport-netdev.c
>> +++ b/datapath/vport-netdev.c
>> @@ -321,7 +321,7 @@ static int netdev_send(struct vport *vport, struct
>> sk_buff *skb)
>>                 if (netif_needs_gso(skb, features)) {
>>                         struct sk_buff *nskb;
>>
>> -                       nskb = skb_gso_segment(skb, features);
>> +                       nskb = __skb_gso_segment(skb, features, true);
>>                         if (!nskb) {
>>                                 if (unlikely(skb_cloned(skb) &&
>>                                     pskb_expand_head(skb, 0, 0,
>> GFP_ATOMIC)))
>
>
> Not sure I understand the rationale for this part of the 3.9 support
> changeset; netdevice.h for the 3.9 kernel in saucy includes:
>
> static inline
> struct sk_buff *skb_gso_segment(struct sk_buff *skb, netdev_features_t
> features)
> {
>         return __skb_gso_segment(skb, features, true);
> }
>
> which makes the change in vport-netdev.c redundant.
>
right, there is no functional change here, I thought it is better to
call skb_gso_segment().

Thanks.



More information about the dev mailing list