[ovs-dev] [PATCH] packets: Fix typo in reserved multicast Ethernet addresses.

Ben Pfaff blp at nicira.com
Wed Jun 5 16:52:26 UTC 2013


Thanks, pushed to master, branch-1.{11,10,9,8}.

On Tue, Jun 04, 2013 at 05:24:46PM -0700, Ethan Jackson wrote:
> Doh
> 
> Acked-by: Ethan Jackson <ethan at nicira.com>
> 
> On Tue, May 28, 2013 at 4:05 PM, Ben Pfaff <blp at nicira.com> wrote:
> > The reserved multicast Ethernet addresses begin with 01:80:c2, not
> > 01:08:c2.
> >
> > Reported-by: Padmanabhan Krishnan <kprad1 at yahoo.com>
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> >  AUTHORS           |    1 +
> >  lib/packets.c     |   32 ++++++++++++++++----------------
> >  tutorial/Tutorial |   12 ++++++------
> >  tutorial/t-stage0 |    2 +-
> >  4 files changed, 24 insertions(+), 23 deletions(-)
> >
> > diff --git a/AUTHORS b/AUTHORS
> > index 498e9f0..6456668 100644
> > --- a/AUTHORS
> > +++ b/AUTHORS
> > @@ -176,6 +176,7 @@ Min Chen                ustcer.tonychan at gmail.com
> >  Murphy McCauley         murphy.mccauley at gmail.com
> >  Mikael Doverhag         mdoverhag at nicira.com
> >  Niklas Andersson        nandersson at nicira.com
> > +Padmanabhan Krishnan    kprad1 at yahoo.com
> >  Pankaj Thakkar          thakkar at nicira.com
> >  Paul Ingram             paul at nicira.com
> >  Paulo Cravero           pcravero at as2594.net
> > diff --git a/lib/packets.c b/lib/packets.c
> > index 77aa7d3..7212d00 100644
> > --- a/lib/packets.c
> > +++ b/lib/packets.c
> > @@ -59,22 +59,22 @@ eth_addr_is_reserved(const uint8_t ea[ETH_ADDR_LEN])
> >
> >      static struct eth_addr_node nodes[] = {
> >          /* STP, IEEE pause frames, and other reserved protocols. */
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c2000000ULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c2000001ULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c2000002ULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c2000003ULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c2000004ULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c2000005ULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c2000006ULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c2000007ULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c2000008ULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c2000009ULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c200000aULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c200000bULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c200000cULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c200000dULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c200000eULL },
> > -        { HMAP_NODE_NULL_INITIALIZER, 0x0108c200000fULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c2000000ULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c2000001ULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c2000002ULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c2000003ULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c2000004ULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c2000005ULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c2000006ULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c2000007ULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c2000008ULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c2000009ULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c200000aULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c200000bULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c200000cULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c200000dULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c200000eULL },
> > +        { HMAP_NODE_NULL_INITIALIZER, 0x0180c200000fULL },
> >
> >          /* Extreme protocols. */
> >          { HMAP_NODE_NULL_INITIALIZER, 0x00e02b000000ULL }, /* EDP. */
> > diff --git a/tutorial/Tutorial b/tutorial/Tutorial
> > index c537bad..0506a20 100644
> > --- a/tutorial/Tutorial
> > +++ b/tutorial/Tutorial
> > @@ -253,7 +253,7 @@ A switch should also not forward IEEE 802.1D Spanning Tree Protocol
> >  packets with reserved multicast protocols:
> >
> >      ovs-ofctl add-flow br0 \
> > -        "table=0, dl_dst=01:08:c2:00:00:00/ff:ff:ff:ff:ff:f0, actions=drop"
> > +        "table=0, dl_dst=01:80:c2:00:00:00/ff:ff:ff:ff:ff:f0, actions=drop"
> >
> >  We could add flows to drop other protocols, but these demonstrate the
> >  pattern.
> > @@ -287,12 +287,12 @@ such a flow would be treated as it goes through the switch.
> >
> >  Try this command:
> >
> > -    ovs-appctl ofproto/trace br0 in_port=1,dl_dst=01:08:c2:00:00:05
> > +    ovs-appctl ofproto/trace br0 in_port=1,dl_dst=01:80:c2:00:00:05
> >
> >  The output should look something like this:
> >
> > -    Flow: metadata=0,in_port=1,vlan_tci=0x0000,dl_src=00:00:00:00:00:00,dl_dst=01:08:c2:00:00:05,dl_type=0x0000
> > -    Rule: table=0 cookie=0 dl_dst=01:08:c2:00:00:00/ff:ff:ff:ff:ff:f0
> > +    Flow: metadata=0,in_port=1,vlan_tci=0x0000,dl_src=00:00:00:00:00:00,dl_dst=01:80:c2:00:00:05,dl_type=0x0000
> > +    Rule: table=0 cookie=0 dl_dst=01:80:c2:00:00:00/ff:ff:ff:ff:ff:f0
> >      OpenFlow actions=drop
> >
> >      Final flow: unchanged
> > @@ -315,11 +315,11 @@ interesting here.
> >
> >  Try another command:
> >
> > -    ovs-appctl ofproto/trace br0 in_port=1,dl_dst=01:08:c2:00:00:10
> > +    ovs-appctl ofproto/trace br0 in_port=1,dl_dst=01:80:c2:00:00:10
> >
> >  The output should be:
> >
> > -    Flow: metadata=0,in_port=1,vlan_tci=0x0000,dl_src=00:00:00:00:00:00,dl_dst=01:08:c2:00:00:10,dl_type=0x0000
> > +    Flow: metadata=0,in_port=1,vlan_tci=0x0000,dl_src=00:00:00:00:00:00,dl_dst=01:80:c2:00:00:10,dl_type=0x0000
> >      Rule: table=0 cookie=0 priority=0
> >      OpenFlow actions=resubmit(,1)
> >
> > diff --git a/tutorial/t-stage0 b/tutorial/t-stage0
> > index 55687ee..63db6f0 100755
> > --- a/tutorial/t-stage0
> > +++ b/tutorial/t-stage0
> > @@ -4,6 +4,6 @@ ovs-ofctl add-flow br0 \
> >      "table=0, dl_src=01:00:00:00:00:00/01:00:00:00:00:00, actions=drop"
> >
> >  ovs-ofctl add-flow br0 \
> > -    "table=0, dl_dst=01:08:c2:00:00:00/ff:ff:ff:ff:ff:f0, actions=drop"
> > +    "table=0, dl_dst=01:80:c2:00:00:00/ff:ff:ff:ff:ff:f0, actions=drop"
> >
> >  ovs-ofctl add-flow br0 "table=0, priority=0, actions=resubmit(,1)"
> > --
> > 1.7.2.5
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list