[ovs-dev] [threads 06/17] lockfile: Remove calls to time_disable_restart()/time_enable_restart().

Ben Pfaff blp at nicira.com
Wed Jun 5 22:05:11 UTC 2013


Applied, thanks.

On Wed, Jun 05, 2013 at 02:07:07PM -0700, Ethan Jackson wrote:
> Acked-by: Ethan Jackson <ethan at nicira.com>
> 
> On Wed, Jun 5, 2013 at 1:05 PM, Ben Pfaff <blp at nicira.com> wrote:
> > These calls are not necessary because F_SETLK does not block.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> >  lib/lockfile.c |    2 --
> >  1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/lockfile.c b/lib/lockfile.c
> > index 3708aec..c37f332 100644
> > --- a/lib/lockfile.c
> > +++ b/lib/lockfile.c
> > @@ -251,9 +251,7 @@ lockfile_try_lock(const char *name, pid_t *pidp, struct lockfile **lockfilep)
> >      l.l_start = 0;
> >      l.l_len = 0;
> >
> > -    time_disable_restart();
> >      error = fcntl(fd, F_SETLK, &l) == -1 ? errno : 0;
> > -    time_enable_restart();
> >
> >      if (!error) {
> >          *lockfilep = lockfile_register(name, s.st_dev, s.st_ino, fd);
> > --
> > 1.7.2.5
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list