[ovs-dev] [xc 2/4] flow: Add new flow_wildcards_fold_minimask() function.

Ben Pfaff blp at nicira.com
Wed Jun 5 23:42:23 UTC 2013


On Wed, Jun 05, 2013 at 03:21:37PM -0700, Justin Pettit wrote:
> From: Ethan Jackson <ethan at nicira.com>
> 
> This function will be useful in a future commit.
> 
> Co-authored-by: Justin Pettit <jpettit at nicira.com>
> Signed-off-by: Justin Pettit <jpettit at nicira.com>

The name flow_wildcards_or_miniflow() threw me for a loop until I read
the function carefully.  Could you add a function-level comment?
Actually, the prefix "flow_wildcards" itself is a little confusing
since the function doesn't use a flow_wildcards anywhere (and
miniflow_expand() doesn't apply it to a flow_wildcards).

Looks good.



More information about the dev mailing list