[ovs-dev] [xc 2/4] flow: Add new flow_wildcards_fold_minimask() function.

Ben Pfaff blp at nicira.com
Thu Jun 6 16:38:08 UTC 2013


On Thu, Jun 06, 2013 at 08:50:35AM -0700, Justin Pettit wrote:
> 
> On Jun 5, 2013, at 4:42 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > On Wed, Jun 05, 2013 at 03:21:37PM -0700, Justin Pettit wrote:
> >> From: Ethan Jackson <ethan at nicira.com>
> >> 
> >> This function will be useful in a future commit.
> >> 
> >> Co-authored-by: Justin Pettit <jpettit at nicira.com>
> >> Signed-off-by: Justin Pettit <jpettit at nicira.com>
> > 
> > The name flow_wildcards_or_miniflow() threw me for a loop until I read
> > the function carefully.  Could you add a function-level comment?
> > Actually, the prefix "flow_wildcards" itself is a little confusing
> > since the function doesn't use a flow_wildcards anywhere (and
> > miniflow_expand() doesn't apply it to a flow_wildcards).
> 
> How about "flow_union_with_miniflow" and the following comment?
> 
> /* Perform a bit-wise OR of miniflow 'src' flow data with the equivilent
>  * fields in 'dst', storing the result in 'dst'. */

"equivalent".

Thanks, that's a lot better.



More information about the dev mailing list