[ovs-dev] [subfacet 3/4] ofproto-dpif: Set flow-eviction-threshold globally.

[Ben Pfaff]

On Wed, Jun 05, 2013 at 01:46:20PM -0700, Ethan Jackson wrote:
> With the signal datapath, it no longer makes sense to have a per

"single" datapath

> ofproto flow eviction threshold.  This patch moves the flow
> eviction threshold to the Open_vSwitch table making the setting
> global, though still treated separately for each ofproto.  A future
> patch will unify flow eviction on a per datapath basis.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

> diff --git a/ofproto/ofproto-provider.h b/ofproto/ofproto-provider.h
> index db0d589..7ca1728 100644
> --- a/ofproto/ofproto-provider.h
> +++ b/ofproto/ofproto-provider.h
> @@ -233,6 +230,11 @@ struct rule {
>                                   * is expirable, otherwise empty. */
>  };
>  
> +/* Threshold at which to begin flow table eviction. Only affects the
> + * ofproto-dpif implementation */
> +static unsigned flow_eviction_threshold OVS_UNUSED =
> +    OFPROTO_FLOW_EVICTION_THRESHOLD_DEFAULT;

Whoa.  Declaring a static variable in a header file?  Far out.  But it
isn't going to work.