[ovs-dev] [PATCH 1/3] megaflow: Add mask attribute to netlink protocol

Andy Zhou azhou at nicira.com
Thu Jun 6 22:15:15 UTC 2013


How about the following change? I choose not to use the term "mega flow"
here to avoid confusing outside people.

diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
index 6e71b4c..203c7eb 100644
--- a/include/linux/openvswitch.h
+++ b/include/linux/openvswitch.h
@@ -410,9 +410,11 @@ struct ovs_key_nd {
  * @OVS_FLOW_ATTR_CLEAR: If present in a %OVS_FLOW_CMD_SET request, clears
the
  * last-used time, accumulated TCP flags, and statistics for this flow.
  * Otherwise ignored in requests.  Never present in notifications.
- * @OVS_FLOW_ATTR_MASK: Optional Nested %OVS_KEY_ATTR_* attributes
specifying
- * the mega flow mask. OVS_KEY_ATTR_* attributes specified only in
OVS_FLOW_ATT
- * but not here will be treated as wildcard field.
+ * @OVS_FLOW_ATTR_MASK: Nested %OVS_KEY_ATTR_* attributes specifying the
+ * mask bits for wildcarded flow match. Mask bit value '1' specifies exact
+ * match with corresponding flow key bit, while mask bit value '0'
specifies
+ * a wildcarded match. Omitting attribute is treated as wildcarding
+ * all corresponding fields. Optional for all requests.


On Thu, Jun 6, 2013 at 10:46 AM, Jesse Gross <jesse at nicira.com> wrote:

> On Wed, Jun 5, 2013 at 10:46 PM, Andy Zhou <azhou at nicira.com> wrote:
> > diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> > index e890fd8..6e71b4c 100644
> > --- a/include/linux/openvswitch.h
> > +++ b/include/linux/openvswitch.h
> > @@ -410,6 +410,9 @@ struct ovs_key_nd {
> >   * @OVS_FLOW_ATTR_CLEAR: If present in a %OVS_FLOW_CMD_SET request,
> clears the
> >   * last-used time, accumulated TCP flags, and statistics for this flow.
> >   * Otherwise ignored in requests.  Never present in notifications.
> > + * @OVS_FLOW_ATTR_MASK: Optional Nested %OVS_KEY_ATTR_* attributes
> specifying
> > + * the mega flow mask. OVS_KEY_ATTR_* attributes specified only in
> OVS_FLOW_ATTR_KEY
> > + * but not here will be treated as wildcard field.
>
> Can you expand this comment a little bit? Outside of people that have
> been working on it, I'm not sure that the term mega flow is really
> self-descriptive.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130606/44a90979/attachment-0003.html>


More information about the dev mailing list