[ovs-dev] [subfacet 4/4] ofproto-dpif: Maintain subfacets in dpif_backer.

Ben Pfaff blp at nicira.com
Thu Jun 6 22:22:05 UTC 2013


On Wed, Jun 05, 2013 at 01:46:21PM -0700, Ethan Jackson wrote:
> Conceptually, a subfacet represents a datapath flow key, and
> therefore belongs more to a datapath more than it does to a bridge.
> This patch moves the subfacet hmap from 'struct ofproto_dpif' to
> 'struct dpif_backer', simplifying the code in the process.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

Practically speaking, there is generally one backer.  So I think that
places where previously the code logged a bridge name, and now logs a
backer name, we might as well drop the name entirely.  This also goes
for the governor, which doesn't seem to need a name at all anymore.

On the same lines, I notice that we have some very simple backer
stats, like subfacet_add_count.  We could make these into coverage
counters.  I don't know whether that is desirable.

Thanks,

Ben.



More information about the dev mailing list