[ovs-dev] [xc 4/4] ofproto-dpif: Track relevant fields for wildcarding and add xout cache.

Rajahalme, Jarno (NSN - FI/Espoo) jarno.rajahalme at nsn.com
Fri Jun 7 06:21:26 UTC 2013

On Jun 7, 2013, at 1:34 , ext Justin Pettit wrote:

> On Jun 5, 2013, at 10:43 PM, Ben Pfaff <blp at nicira.com> wrote:
>> I think that struct xout_cache could use a top-level comment
>> explaining its purpose and how it generally fits in with the rest of
>> the system.
> /* A cache of xlate_out (xout) translations.  Facets that depend on the
> * same flow fields have the same xout entries, so the cache saves on
> * needless action translations and redundant copies of xout structures. */

I was perplexed for a while by the "struct xout_cache" and the 'xout_cache'
member of struct ofproto_dpif. The first one is a cache entry, while the latter
is the cache. While the comments on the members mention "entry", maybe the
comment above should as well.

Also, as it is possible for two facets that depend only on e.g. the 'in_port'
field to have completely different actions, you could be more specific with
the comment above.


More information about the dev mailing list