[ovs-dev] [PATCH v12 1/8] ofproto-dpif: Actually log errors in facet_check_consistency()

Simon Horman horms at verge.net.au
Fri Jun 7 06:28:54 UTC 2013


Thanks.

On Thu, Jun 06, 2013 at 11:17:09AM -0700, Ethan Jackson wrote:
> Applied with some minor tweaks to the commit message.  Thanks Simon.
> 
> Ethan
> 
> On Wed, Jun 5, 2013 at 1:50 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Wed, Jun 05, 2013 at 02:28:47PM +0900, Simon Horman wrote:
> >> facet_check_consistency() goes to some effort to create informative
> >> error messages, protected by a rate limit, but does not actually
> >> log these messages.
> >>
> >> This appears to be an unintended side effect of
> >> 4dff90977694784e67e9c08cc72dee28ebc343ae ("ofproto-dpif: Move odp_actions
> >> from subfacet to facet.").  This patch restores the logging behaviour
> >> present prior to the above commit.
> >>
> >> This patch also revers a changes made by the same commit to use
> >> ds_put_cstr() instead of ds_put_char() in facet_check_consistency().
> >>
> >> Cc: Justin Pettit <jpettit at nicira.com>
> >> Cc: Ethan Jackson <ethan at nicira.com>
> >> Signed-off-by: Simon Horman <horms at verge.net.au>
> >
> > Ethan, will you review this one?
> 



More information about the dev mailing list