[ovs-dev] [subfacet 4/4] ofproto-dpif: Maintain subfacets in dpif_backer.
ethan at nicira.com
Fri Jun 7 20:37:48 UTC 2013
> Practically speaking, there is generally one backer. So I think that
> places where previously the code logged a bridge name, and now logs a
> backer name, we might as well drop the name entirely. This also goes
> for the governor, which doesn't seem to need a name at all anymore.
Fine with me, see the incremental below.
> On the same lines, I notice that we have some very simple backer
> stats, like subfacet_add_count. We could make these into coverage
> counters. I don't know whether that is desirable.
I agree. I have Alex looking at it now.
ofproto/ofproto-dpif.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 86587eb..d0b0aad 100644
@@ -4417,8 +4417,7 @@ delete_unexpected_flow(struct dpif_backer *backer,
odp_flow_key_format(key, key_len, &s);
- VLOG_WARN("unexpected flow on %s: %s", dpif_name(backer->dpif),
+ VLOG_WARN("unexpected flow: %s", ds_cstr(&s));
@@ -4559,7 +4558,7 @@ subfacet_max_idle(const struct dpif_backer *backer)
ds_put_format(&s, " %d:%d", i * BUCKET_WIDTH, buckets[i]);
- VLOG_INFO("%s: %s (msec:count)", dpif_name(backer->dpif), ds_cstr(&s));
+ VLOG_INFO("%s (msec:count)", ds_cstr(&s));
More information about the dev