[ovs-dev] [PATCH] ovsdb-idlc: Write a new-line at the end of "annotate" output.
Ben Pfaff
blp at nicira.com
Mon Jun 10 17:26:27 UTC 2013
Thanks, applied to master and branch-1.{11,10,9}.
On Sat, Jun 08, 2013 at 01:27:07PM -0700, Ethan Jackson wrote:
> Acked-by: Ethan Jackson <ethan at nicira.com>
>
> On Fri, Jun 7, 2013 at 3:05 PM, Ben Pfaff <blp at nicira.com> wrote:
> > Some tools do not like text files that lack a trailing new-line. In
> > particular, Debian's dpkg-source utility complains about a missing new-line
> > in the file generated by ovsdb-idlc:
> >
> > dpkg-source: warning: file
> > openvswitch-1.9.2+git20130605/lib/vswitch-idl.ovsidl has no final
> > newline (either original or modified version)
> >
> > This commit fixes the problem.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> > ovsdb/ovsdb-idlc.in | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/ovsdb/ovsdb-idlc.in b/ovsdb/ovsdb-idlc.in
> > index 1f21950..6d49dd6 100755
> > --- a/ovsdb/ovsdb-idlc.in
> > +++ b/ovsdb/ovsdb-idlc.in
> > @@ -18,6 +18,7 @@ def annotateSchema(schemaFile, annotationFile):
> > schemaJson = ovs.json.from_file(schemaFile)
> > execfile(annotationFile, globals(), {"s": schemaJson})
> > ovs.json.to_stream(schemaJson, sys.stdout)
> > + sys.stdout.write('\n')
> >
> > def constify(cType, const):
> > if (const and cType.endswith('*') and not cType.endswith('**')):
> > --
> > 1.7.2.5
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
More information about the dev
mailing list