[ovs-dev] [PATCH 3/3] rtnetlink-link: Make 'attrs' local variable non-static.

Gurucharan Shetty shettyg at nicira.com
Mon Jun 10 21:13:26 UTC 2013


On Mon, Apr 29, 2013 at 3:23 PM, Ben Pfaff <blp at nicira.com> wrote:

> I don't see any reason for this variable to be static.
>
Looks good to me, thanks.

>
> CC: Ethan Jackson <ethan at nicira.com>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  lib/rtnetlink-link.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/rtnetlink-link.c b/lib/rtnetlink-link.c
> index 0b3710f..459e485 100644
> --- a/lib/rtnetlink-link.c
> +++ b/lib/rtnetlink-link.c
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2009, 2010 Nicira, Inc.
> + * Copyright (c) 2009, 2010, 2013 Nicira, Inc.
>   *
>   * Licensed under the Apache License, Version 2.0 (the "License");
>   * you may not use this file except in compliance with the License.
> @@ -49,7 +49,7 @@ rtnetlink_link_parse(struct ofpbuf *buf,
>          [IFLA_ADDRESS] = { .type = NL_A_UNSPEC, .optional = true },
>      };
>
> -    static struct nlattr *attrs[ARRAY_SIZE(policy)];
> +    struct nlattr *attrs[ARRAY_SIZE(policy)];
>
>      parsed = nl_policy_parse(buf, NLMSG_HDRLEN + sizeof(struct ifinfomsg),
>                               policy, attrs, ARRAY_SIZE(policy));
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130610/a2ae3c63/attachment-0003.html>


More information about the dev mailing list