[ovs-dev] [threads 13/17] ofp-print: Avoid returning static data.

Ben Pfaff blp at nicira.com
Wed Jun 12 21:49:07 UTC 2013


On Wed, Jun 12, 2013 at 02:46:57PM -0700, Justin Pettit wrote:
> On Jun 12, 2013, at 2:44 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > I added:
> > /* Returns a string form of 'reason'.  The return value is either a statically
> > * allocated constant string or the 'bufsize'-byte buffer 'reasonbuf'.
> > * 'bufsize' should be at least OFP_FLOW_REMOVED_REASON_BUFSIZE. */
> > 
> > How's that?
> 
> Looks good.  I assume you'll add a similar comment to the port function?

Oops, thanks for pointing that out.  I'll fix that one the same way
and push.



More information about the dev mailing list