[ovs-dev] [PATCH net-next 4/4] openvswitch: make skb->csum consistent with rest of networking stack.

Pravin Shelar pshelar at nicira.com
Thu Jun 13 16:14:25 UTC 2013


On Wed, Jun 12, 2013 at 7:52 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Wed, Jun 12, 2013 at 3:57 PM, Pravin B Shelar <pshelar at nicira.com> wrote:
>> diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
>> index 39cd821..e6ffb82 100644
>> --- a/net/openvswitch/datapath.c
>> +++ b/net/openvswitch/datapath.c
>> @@ -406,6 +406,7 @@ static int queue_userspace_packet(struct net *net, int dp_ifindex,
>>                 nskb = __vlan_put_tag(nskb, nskb->vlan_proto, vlan_tx_tag_get(nskb));
>>                 if (!nskb)
>>                         return -ENOMEM;
>> +               ovs_skb_postpush_rcsum(skb, skb->data + (2 * ETH_ALEN), VLAN_HLEN);
>
> This shouldn't be necessary since the packet is going to userspace,
> which won't use the skb->csum value.
ok, I will update patch.



More information about the dev mailing list