[ovs-dev] [PATCH] tunnel: Don't wildcard TTL and TOS in some circumstances.

Ben Pfaff blp at nicira.com
Fri Jun 14 00:03:13 UTC 2013


On Thu, Jun 13, 2013 at 04:53:25PM -0700, Justin Pettit wrote:
> For tunnels, we need to handle the facet's wildcards specially in a
> couple of cases:
> 
>     - Don't wildcard TTL for facets if "ttl" option is "inherit".
>     - Never wildcard the ECN bits, since they are always inherited.
>     - Wildcard the rest of the TOS field if the "tos" option is "inherit".
> 
> Issue #17911
> 
> Signed-off-by: Justin Pettit <jpettit at nicira.com>

I think that this:
        wc->masks.nw_tos = IP_ECN_MASK;
should be
        wc->masks.nw_tos |= IP_ECN_MASK;
but otherwise this looks good.



More information about the dev mailing list