[ovs-dev] [PATCH] tunnel: Don't wildcard TTL and TOS in some circumstances.
jpettit at nicira.com
Fri Jun 14 00:27:30 UTC 2013
On Jun 13, 2013, at 5:03 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Jun 13, 2013 at 04:53:25PM -0700, Justin Pettit wrote:
>> For tunnels, we need to handle the facet's wildcards specially in a
>> couple of cases:
>> - Don't wildcard TTL for facets if "ttl" option is "inherit".
>> - Never wildcard the ECN bits, since they are always inherited.
>> - Wildcard the rest of the TOS field if the "tos" option is "inherit".
>> Issue #17911
>> Signed-off-by: Justin Pettit <jpettit at nicira.com>
> I think that this:
> wc->masks.nw_tos = IP_ECN_MASK;
> should be
> wc->masks.nw_tos |= IP_ECN_MASK;
> but otherwise this looks good.
Whoops. You're right. Fixed.
I pushed this to master and branch-1.11.
More information about the dev