[ovs-dev] [PATCH net-next 09/12] openvswitch: Add tunneling interface.

Pravin Shelar pshelar at nicira.com
Sat Jun 15 02:17:37 UTC 2013


On Fri, Jun 14, 2013 at 5:23 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Thu, Jun 13, 2013 at 11:24 AM, Pravin B Shelar <pshelar at nicira.com> wrote:
>> diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
>> index fba57a0..575c0bd 100644
>> --- a/net/openvswitch/flow.c
>> +++ b/net/openvswitch/flow.c
>>  static int ipv4_flow_from_nlattrs(struct sw_flow_key *swkey, int *key_len,
>> @@ -938,14 +942,14 @@ static int parse_flow_nlattrs(const struct nlattr *attr,
>>                 u16 type = nla_type(nla);
>>                 int expected_len;
>>
>> -               if (type > OVS_KEY_ATTR_MAX || attrs & (1 << type))
>> +               if (type > OVS_KEY_ATTR_MAX || attrs & (1ULL << type))
>
> The use of 1ULL (64-bit flags) is from the old compatibility code so
> it's not needed anymore.
>
ok.
>> +int ipv4_tun_from_nlattr(const struct nlattr *attr,
>> +                        struct ovs_key_ipv4_tunnel *tun_key)
>
> We should prefix these function names with ovs_.

ok. I will update patch.



More information about the dev mailing list