[ovs-dev] [PATCH 1/2] ofproto-dpif: Move process_special() to ofproto-dpif-xlate.c.

Justin Pettit jpettit at nicira.com
Tue Jun 18 07:11:08 UTC 2013

On Jun 17, 2013, at 6:26 PM, Ethan Jackson <ethan at nicira.com> wrote:

> Acked-by: Ethan Jackson <ethan at nicira.com>
> I'd go ahead and just move stp_should_process_flow() and
> stp_process_packet() into ofproto-dpif-xlate as part of this patch.
> I'm planning to do it anyways as part of my larger restructuring.
> It's fine as is though if you'd prefer to leave it.

Since a bunch of the other STP related functions are in there, I just left it.  We should probably move all of those functions into stp.{ch} for consistency.  It sounded like you were going to be moving a bunch of that stuff with your ofproto-dpif restructuring.

Thanks for the review.  I pushed this to master.


More information about the dev mailing list