[ovs-dev] [PATCH] hindex: New data structure for hashed multimaps.

Ben Pfaff blp at nicira.com
Tue Jun 18 17:28:04 UTC 2013


On Tue, Jun 18, 2013 at 05:09:58PM +0000, Rajahalme, Jarno (NSN - FI/Espoo) wrote:
> All looks good and tests pass. However, I'd probably add a comment
> on the hindex.mask (in hindex.h) stating that it has a number of
> lowest order bits set, others cleared. After realizing that reading
> the code became a bit easier..

That is a good idea.  I wrote it like this:

    size_t mask;      /* 0 or more lowest-order bits set, others cleared. */
 
> I also changed the cookie indexing to use this and it also passes
> all tests and seems to work as expected in my performance tests.

Thank you.  I will apply this soon.



More information about the dev mailing list