[ovs-dev] [PATCH 1/2] ofproto-dpif: Reconfigure tunnel in port_modified().

Ethan Jackson ethan at nicira.com
Tue Jun 18 20:18:21 UTC 2013


Yep I'm confident it will work there.  The only events which require
tunnel reconfiguration are netdev config changes (which generate a
port_modified()) or an odp_port number change which is handled
separately.

Ethan

On Tue, Jun 18, 2013 at 1:11 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Tue, Jun 18, 2013 at 01:07:51PM -0700, Ethan Jackson wrote:
>> > port_modified() only gets called when a port changes in a couple of
>> > specific ways.  port_run() gets called all the time.  Does it matter?
>>
>> It doesn't matter in particular, I did it to be consistent with the
>> next patch.  I'm happy to drop it if you'd prefer.
>
> I'd rather have it in port_modified() if it will work there.  You
> think that it will?  If so, commit it.



More information about the dev mailing list