[ovs-dev] [PATCH] ofproto-dpif: Tighten up megaflow wildcard handling.

Ben Pfaff blp at nicira.com
Wed Jun 19 16:21:23 UTC 2013


On Wed, Jun 19, 2013 at 12:02:10AM -0700, Justin Pettit wrote:
> A number of use-cases weren't handled properly when determining what can
> be wildcarded for megaflows.  This commit both catches additional fields
> that cannot be wildcarded and loosens a few other cases.
> 
> Bug #17979
> 
> Signed-off-by: Justin Pettit <jpettit at nicira.com>

Why does ipfix need to un-wildcard fields?

I don't understand the change in compose_output_action__().  It adds
the ECN bits to the mask but I don't see anything there that depends
on those bits.

In do_xlate_actions(), why do OFPACT_SET_VLAN_VID and
OFPACT_SET_VLAN_PCP have new dependencies?  They do not read the
fields that they add to the mask.

Thanks,

Ben.



More information about the dev mailing list